Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contains_key to SortedIndexMultiMap #108571

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add contains_key to SortedIndexMultiMap #108571

merged 1 commit into from
Mar 1, 2023

Conversation

Jesse-Bakker
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2023
@Noratrieb
Copy link
Member

Do you have a need for this? This is simple so it seems fine anyways, but we usually only add these methods as needed.

@Jesse-Bakker
Copy link
Contributor Author

Jesse-Bakker commented Feb 28, 2023 •
edited
Loading

I was playing around with some optimizations using SortedIndexMultiMap and ran into a need for this. I thought I'd contribute it in a small PR, but I can also add it in a possible PR where I end up using it if you prefer.

@Noratrieb
Copy link
Member

r? Nilstrieb
Looks good, if you've had a need the we can definitely add it.

@rustbot rustbot assigned Noratrieb and unassigned petrochenkov Feb 28, 2023
@Noratrieb
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 28, 2023

📌 Commit edf0530 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 1, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2023
@bors
Auto merge of rust-lang#108587 - matthiaskrgr:rollup-rw6po59, r=matth…
bcb610d 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#108376 (compiler/rustc_session: fix sysroot detection logic)
 - rust-lang#108400 (add llvm cgu instructions stats to perf)
 - rust-lang#108496 (fix rust-lang#108495, postfix decrement and prefix decrement has no warning)
 - rust-lang#108505 (Further unify validity intrinsics)
 - rust-lang#108520 (Small cleanup to `one_bound_for_assoc_type`)
 - rust-lang#108560 (Some `infer/mod.rs` cleanups)
 - rust-lang#108563 (Make mailmap more correct)
 - rust-lang#108564 (Fix `x clean` with specific paths)
 - rust-lang#108571 (Add contains_key to SortedIndexMultiMap)
 - rust-lang#108578 (Update Fuchsia platform team members)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1685894 into rust-lang:master Mar 1, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Jesse-Bakker @rustbot @Noratrieb @bors @petrochenkov